Thread (23 messages) flat view 23 messages, 4 authors, 2017-01-26

Re: [PATCH net v2 3/4] r8152: re-schedule napi for tx

From: Eric Dumazet <hidden>
Date: 2017-01-25 13:57:22
Also in: lkml

On Wed, 2017-01-25 at 16:13 +0800, Hayes Wang wrote:
quoted hunk ↗ jump to hunk
Re-schedule napi after napi_complete() for tx, if it is necessay.

In r8152_poll(), if the tx is completed after tx_bottom() and before
napi_complete(), the scheduling of napi would be lost. Then, no
one handles the next tx until the next napi_schedule() is called.

Signed-off-by: Hayes Wang <redacted>
---
 drivers/net/usb/r8152.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index ec882be..45d168e 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1936,6 +1936,9 @@ static int r8152_poll(struct napi_struct *napi, int budget)
 		napi_complete(napi);
 		if (!list_empty(&tp->rx_done))
 			napi_schedule(napi);
+		else if (!skb_queue_empty(&tp->tx_queue) &&
+			 !list_empty(&tp->tx_free))
+			napi_schedule(&tp->napi);
Why using &tp->napi instead of napi here, as done 3 lines above ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help