Thread (4 messages) flat view 4 messages, 4 authors, 2017-01-24

Re: [PATCH][V3][net-next] net: sctp: fix array overrun read on sctp_timer_tbl

From: David Miller <davem@davemloft.net>
Date: 2017-01-24 20:24:57
Also in: linux-sctp, lkml

From: Colin King <redacted>
Date: Tue, 24 Jan 2017 09:25:54 +0000
From: Colin Ian King <redacted>

Table sctp_timer_tbl is missing a TIMEOUT_RECONF string so
add this in. Also compare timeout with the size of the array
sctp_timer_tbl rather than SCTP_EVENT_TIMEOUT_MAX.  Also add
a build time check that SCTP_EVENT_TIMEOUT_MAX is correct
so we don't ever get this kind of mismatch between the table
and SCTP_EVENT_TIMEOUT_MAX in the future.

Kudos to Marcelo Ricardo Leitner for spotting the missing string
and suggesting the build time sanity check.

Fixes CoverityScan CID#1397639 ("Out-of-bounds read")

Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer")
Signed-off-by: Colin Ian King <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help