Thread (2 messages) 2 messages, 2 authors, 2017-01-24

Re: [PATCH] bpf: don't kfree an uninitialized im_node

From: Alexei Starovoitov <hidden>
Date: 2017-01-24 17:53:59
Also in: kernel-janitors, lkml

On Tue, Jan 24, 2017 at 6:16 AM, Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

There are some error exit paths to the label 'out' that end up
kfree'ing an uninitialized im_node.  Fix this by inititializing
im_node to NULL to avoid kfree'ing a garbage address.
this fix already landed. See:
commit d140199af510 ("bpf, lpm: fix kfree of im_node in trie_update_elem")
Issue found by CoverityScan, CID#1398022 ("Uninitialized pointer read")
Nice. Good to know that static analysis can do such checks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help