Re: [PATCH V2] audit: log 32-bit socketcalls

On Mon, Jan 16, 2017 at 1:27 PM, David Miller [off-list ref] wrote:

From: Richard Guy Briggs <redacted>
Date: Fri, 13 Jan 2017 04:51:48 -0500

quoted

diff --git a/include/linux/audit.h b/include/linux/audit.h
index 9d4443f..43d8003 100644
--- a/include/linux/audit.h
+++ b/include/linux/audit.h

@@ -387,6 +387,18 @@ static inline int audit_socketcall(int nargs, unsigned long *args)
              return __audit_socketcall(nargs, args);
      return 0;
 }
+static inline int audit_socketcall_compat(int nargs, u32 *args)
+{

Please put an empty line between function definitions.

David, assuming Richard makes your requested changes, any objection if
I merge this via the audit tree instead of the netdev tree?  It's a
bit easier for us from a testing perspective this way ...

quoted

+     if (unlikely(!audit_dummy_context())) {
+             int i;
+             unsigned long a[AUDITSC_ARGS];

Please order local variable declarations from longest to shortest line.

quoted

+
+             for (i=0; i<nargs; i++)

Please put a space around operators such as "=" and "<".

quoted

+                     a[i] = (unsigned long)args[i];
+             return __audit_socketcall(nargs, a);
+     }
+     return 0;
+}
 static inline int audit_sockaddr(int len, void *addr)

Again, empty line between function definitions please.

quoted

@@ -781,14 +782,24 @@ COMPAT_SYSCALL_DEFINE5(recvmmsg, int, fd, struct compat_mmsghdr __user *, mmsg,

 COMPAT_SYSCALL_DEFINE2(socketcall, int, call, u32 __user *, args)
 {
+     unsigned int len;
      int ret;
-     u32 a[6];
+     u32 a[AUDITSC_ARGS];
      u32 a0, a1;

Longest to shortest line for local variable declarations please.

--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit

-- 
paul moore
www.paul-moore.com