Thread (3 messages) flat view 3 messages, 3 authors, 2017-01-13

Re: [PATCH v2] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: David Miller <davem@davemloft.net>
Date: 2017-01-13 17:32:15
Also in: lkml, sparclinux

From: Shannon Nelson <redacted>
Date: Thu, 12 Jan 2017 14:24:58 -0800
Fix up a data alignment issue on sparc by swapping the order
of the cookie byte array field with the length field in
struct tcp_fastopen_cookie, and making it a proper union
to clean up the typecasting.

This addresses log complaints like these:
    log_unaligned: 113 callbacks suppressed
    Kernel unaligned access at TPC[976490] tcp_try_fastopen+0x2d0/0x360
    Kernel unaligned access at TPC[9764ac] tcp_try_fastopen+0x2ec/0x360
    Kernel unaligned access at TPC[9764c8] tcp_try_fastopen+0x308/0x360
    Kernel unaligned access at TPC[9764e4] tcp_try_fastopen+0x324/0x360
    Kernel unaligned access at TPC[976490] tcp_try_fastopen+0x2d0/0x360

Cc: Eric Dumazet <redacted>
Signed-off-by: Shannon Nelson <redacted>
---
v2: Use Eric's suggestion for a union in the struct
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help