Re: net: wireless: ath: wil6210: constify cfg80211_ops structures
From: Kalle Valo <hidden>
Date: 2017-01-12 10:55:55
Also in:
linux-wireless, lkml
From: Kalle Valo <hidden>
Date: 2017-01-12 10:55:55
Also in:
linux-wireless, lkml
Bhumika Goyal [off-list ref] wrote:
cfg80211_ops structures are only passed as an argument to the function
wiphy_new. This argument is of type const, so cfg80211_ops strutures
having this property can be declared as const.
Done using Coccinelle
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct cfg80211_ops i@p = {...};
@ok1@
identifier r1.i;
position p;
@@
wiphy_new(&i@p,...)
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct cfg80211_ops i;
File size before:
text data bss dec hex filename
18133 6632 0 24765 60bd wireless/ath/wil6210/cfg80211.o
File size after:
text data bss dec hex filename
18933 5832 0 24765 60bd wireless/ath/wil6210/cfg80211.o
Signed-off-by: Bhumika Goyal <redacted>Patch applied to ath-next branch of ath.git, thanks. b59eb96181e7 wil6210: constify cfg80211_ops structures -- https://patchwork.kernel.org/patch/9479127/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches