Thread (20 messages) flat view 20 messages, 6 authors, 2017-01-13

RE: [PATCH v2 8/8] crypto/testmgr: Allocate only the required output size for hash tests

From: David Laight <hidden>
Date: 2017-01-11 15:14:00
Also in: linux-crypto, lkml

From: Andy Lutomirski
Sent: 10 January 2017 23:25
There are some hashes (e.g. sha224) that have some internal trickery
to make sure that only the correct number of output bytes are
generated.  If something goes wrong, they could potentially overrun
the output buffer.

Make the test more robust by allocating only enough space for the
correct output size so that memory debugging will catch the error if
the output is overrun.
Might be better to test this by allocating an overlong buffer
and then explicitly checking that the output hasn't overrun
the allowed space.

If nothing else the error message will be clearer.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help