Re: [PATCH net-next 5/8] net: dsa: Export dev_to_net_device()
From: David Miller <davem@davemloft.net>
Date: 2017-01-11 02:25:01
Also in:
linux-arm-kernel, lkml
From: Florian Fainelli <f.fainelli@gmail.com> Date: Tue, 10 Jan 2017 12:12:32 -0800
quoted hunk ↗ jump to hunk
@@ -491,7 +491,7 @@ struct mii_bus *dsa_host_dev_to_mii_bus(struct device *dev) } EXPORT_SYMBOL_GPL(dsa_host_dev_to_mii_bus); -static struct net_device *dev_to_net_device(struct device *dev) +struct net_device *dev_to_net_device(struct device *dev) { struct device *d;@@ -508,6 +508,7 @@ static struct net_device *dev_to_net_device(struct device *dev) return NULL; } +EXPORT_SYMBOL_GPL(dev_to_net_device);
Something like this, a public interface with a very high level generic name, doesn't belong in the DSA layer. It belongs in net/core/dev.c or something like that.