Re: [PATCHv1 1/7] TAP: Refactoring macvtap.c

On Sat, Jan 7, 2017 at 12:33 AM, Sainath Grandhi
[off-list ref] wrote:

macvtap module has code for tap/queue management and link management. This patch splits
the code into macvtap_main.c for link management and tap.c for tap/queue management.
Functionality in tap.c can be re-used for implementing tap on other virtual interfaces.

Signed-off-by: Sainath Grandhi <redacted>
Tested-by: Sainath Grandhi <redacted>
---
 drivers/net/Makefile       |    2 +
 drivers/net/macvtap.c      | 1374 --------------------------------------------
 drivers/net/macvtap_main.c |  218 +++++++
 drivers/net/tap.c          | 1186 ++++++++++++++++++++++++++++++++++++++
 include/linux/if_macvtap.h |   10 +
 5 files changed, 1416 insertions(+), 1374 deletions(-)
 delete mode 100644 drivers/net/macvtap.c
 create mode 100644 drivers/net/macvtap_main.c
 create mode 100644 drivers/net/tap.c
 create mode 100644 include/linux/if_macvtap.h

Can you use -M -C for better view of this change? It's really hard to review.


-- 
With Best Regards,
Andy Shevchenko