Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2

Hi Andrew,

Andrew Lunn [off-list ref] writes:

On Tue, Jan 03, 2017 at 01:15:35PM -0500, Vivien Didelot wrote:

quoted

The current HWMON support in DSA in embedded in the legacy code.
Extract it to its own file and register it in the newer DSA code.

I would really prefer not to do this.

The temperature sensor is in the embedded PHYs of the switch. Many of
Marvell discrete PHYs also have the same temperature sensor. The
correct thing to do is move this code into drivers/net/phy/marvell.c.

I agree that the temperature code in the mv88e6xxx driver must be moved
to the Marvell PHY driver.

However I still think this patchset is still valuable because at least
it isolates the HWMON code in DSA which is good, and I think some chips
do have temperature sensors in their cores, not in their PHYs. So the
new DSA code should benefit from the HWMON support instead of
considering this a regression for its users.

Thanks,

        Vivien