Re: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.

On Tue, Jan 03, 2017 at 10:36:11AM +0530, Harini Katakam wrote:

I understand that it is not accurate - it is an initial version.

No, it is not inaccurate at all, it is WRONG.

This means that time stamps will be randomly associated with PTP
network packets.  To the application, the protocol will appear to
work, but the time stamp information (and thus the synchronization)
will be wrong.

To me, this is unacceptable, and I will push back on this driver
getting merged.

[ In contrast, the descriptor based approach would be ok, afaict. ]

Thanks,
Richard