Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr()

From: Lorenzo Colitti <redacted>
Date: Sun, 1 Jan 2017 16:57:23 +0900

On Sat, Dec 31, 2016 at 8:42 AM, Eric Biggers [off-list ref] wrote:

quoted

->setattr() was recently implemented for socket files to sync the socket
inode's uid to the new 'sk_uid' member of struct sock.  It does this by
copying over the ia_uid member of struct iattr.  However, ia_uid is
actually only valid when ATTR_UID is set in ia_valid, indicating that
the uid is being changed, e.g. by chown.
[...]
-       if (!err) {
+       if (!err && (iattr->ia_valid & ATTR_UID)) {

Oops. Thanks for fixing this. Unit tested in
https://android-review.googlesource.com/316594 .

Tested-by: Lorenzo Colitti <redacted>
Acked-by: Lorenzo Colitti <redacted>

Applied, thanks everyone.