Re: [PATCH net-next 4/5] bridge: per vlan dst_metadata netlink support

Hi Roopa,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Roopa-Prabhu/bridge-per-vlan-dst_metadata-support/20170131-140750
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   net/bridge/br_netlink_tunnel.c: In function 'br_parse_vlan_tunnel_info':

quoted

net/bridge/br_netlink_tunnel.c:251:15: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]

     tinfo->flags = flags;
     ~~~~~~~~~~~~~^~~~~~~

vim +/flags +251 net/bridge/br_netlink_tunnel.c

   235	
   236		err = nla_parse_nested(tb, IFLA_BRIDGE_VLAN_TUNNEL_MAX,
   237				       attr, vlan_tunnel_policy);
   238		if (err < 0)
   239			return err;
   240	
   241		tun_id = nla_get_u32(tb[IFLA_BRIDGE_VLAN_TUNNEL_ID]);
   242		vid = nla_get_u16(tb[IFLA_BRIDGE_VLAN_TUNNEL_VID]);
   243		if (vid >= VLAN_VID_MASK)
   244			return -ERANGE;
   245	
   246		if (tb[IFLA_BRIDGE_VLAN_TUNNEL_FLAGS])
   247			flags = nla_get_u16(tb[IFLA_BRIDGE_VLAN_TUNNEL_FLAGS]);
   248	
   249		tinfo->tunid = tun_id;
   250		tinfo->vid = vid;
 > 251		tinfo->flags = flags;
   252	
   253		return 0;
   254	}
   255	
   256	int br_process_vlan_tunnel_info(struct net_bridge *br,
   257					struct net_bridge_port *p, int cmd,
   258					struct vtunnel_info *tinfo_curr,
   259					struct vtunnel_info *tinfo_last)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation