Thread (5 messages) flat view 5 messages, 2 authors, 2017-01-25

Re: [PATCH net-next] tcp: reduce skb overhead in selected places

From: Eric Dumazet <hidden>
Date: 2017-01-25 18:39:03

On Wed, 2017-01-25 at 13:17 -0500, David Miller wrote:
Applied, thanks Eric.
Thanks David.

It looks IPv6 potential big network headers are also a threat :

Various pskb_may_pull() to pull headers might reallocate skb->head,
but skb->truesize is not updated in __pskb_pull_tail()

We probably need to update skb->truesize, but it is tricky as the prior
skb->truesize value might have been used for memory accounting when skb
was stored in some queue.

Do you think we could change __pskb_pull_tail() right away and fix the
few places that would break, or should we add various helpers with extra
parameters to take a safe route ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help