Thread (7 messages) 7 messages, 3 authors, 2017-01-24

Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

flat view

From: Roopa Prabhu <hidden>
Date: 2017-01-23 16:31:29

On 1/23/17, 12:55 AM, Jiri Benc wrote:
On Fri, 20 Jan 2017 23:43:18 -0800, Roopa Prabhu wrote:
quoted
This patch skips flushing static fdb entries in
ndo_stop, but flushes all fdb entries during vxlan
device delete. This is consistent with the bridge
driver fdb
This makes sense but isn't this a uAPI change? Do you know whether
there are users relying on the current behavior?
yeah, i have debated about this also. I am sitting on a stash of such patches
which are borderline bug fixes but been out there long enough that people might care.

I leaned towards making it the default because,
- I am assuming not many people use static entries
- and people will not be very unhappy with this change....because it does not delete something
 they had...just retains them.
- Per device flag seems like an overkill here

Also, i think some such changes were done to the bridge driver too after it was out.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help