Thread (8 messages) flat view 8 messages, 3 authors, 2017-01-21

Re: [PATCH] net: qcom/emac: claim the irq only when the device is opened

From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: 2017-01-20 20:45:22

Hi,

On 18.01.2017 22:42, Timur Tabi wrote:
quoted hunk ↗ jump to hunk
@@ -1029,8 +1017,6 @@ void emac_mac_down(struct emac_adapter *adpt)
  	 */
  	writel(DIS_INT, adpt->base + EMAC_INT_STATUS);
  	writel(0, adpt->base + EMAC_INT_MASK);
-	synchronize_irq(adpt->irq.irq);
There is no reason to remove the irq synchronization, is it?
Note that the desriptors are freed after that so we must be sure that
the irq handler is not running any more.

Regards,
Lino
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help