Re: [PATCH] net: ethernet: aquantia: fix alloc_cast.cocci warnings
From: Joe Perches <joe@perches.com>
Date: 2017-01-20 08:20:01
On Thu, 2017-01-19 at 17:09 +0800, kbuild test robot wrote:
drivers/net/ethernet/aquantia/atlantic/aq_ring.c:24:20-41: WARNING: casting value returned by memory allocation function to (struct aq_ring_buff_s *) is useless. Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc.
[]
quoted hunk ↗ jump to hunk
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c@@ -21,7 +21,7 @@ static struct aq_ring_s *aq_ring_alloc(s { int err = 0; - self->buff_ring = (struct aq_ring_buff_s *) + self->buff_ring = kzalloc(sizeof(struct aq_ring_buff_s) * self->size, GFP_KERNEL);
This should likely be kcalloc