Re: [PATCH net-next v4 2/2] net sched: Trivial whitespace and stylistic changes
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: 2017-01-17 16:31:02
Jiri, I am going to drop this patch altogether. Someday i will do the cleanup. cheers, jamal On 17-01-17 07:12 AM, Jiri Pirko wrote:
Tue, Jan 17, 2017 at 12:11:49PM CET, jhs@mojatatu.com wrote:quoted
From: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com> ---[...]quoted
-static inline unsigned long -cls_set_class(struct tcf_proto *tp, unsigned long *clp, +static inline unsigned long cls_set_class(struct tcf_proto *tp, + unsigned long *clp, unsigned long cl)While you are at it, you can align this as well.quoted
{ unsigned long old_cl; -This empty line should definitelly stay.quoted
tcf_tree_lock(tp); old_cl = __cls_set_class(clp, cl); tcf_tree_unlock(tp); - return old_cl; }[...]quoted
@@ -237,7 +232,6 @@ static inline int tcf_em_early_end(struct tcf_ematch *em, int result)return 0; } -This empty line should stay.quoted
/** * struct tcf_ematch_tree - ematch tree handle *@@ -246,8 +240,7 @@ static inline int tcf_em_early_end(struct tcf_ematch *em, int result) */struct tcf_ematch_tree { struct tcf_ematch_tree_hdr hdr; - struct tcf_ematch * matches; - + struct tcf_ematch *matches;Well, to be pedantic, this still looks odd :)quoted
};