Thread (10 messages) 10 messages, 3 authors, 2017-01-17

Re: [PATCH v4 0/4] vsock: cancel connect packets when failing to connect

From: Jorgen S. Hansen <hidden>
Date: 2017-01-17 09:25:26
Also in: kvm

On Jan 9, 2017, at 11:06 AM, Stefan Hajnoczi [off-list ref] wrote:

On Fri, Jan 06, 2017 at 10:22:56AM +0800, Peng Tao wrote:
quoted
On Tue, Dec 13, 2016 at 5:50 PM, Stefan Hajnoczi [off-list ref] wrote:
quoted
On Mon, Dec 12, 2016 at 08:21:05PM +0800, Peng Tao wrote:
quoted
Currently, if a connect call fails on a signal or timeout (e.g., guest is still
in the process of starting up), we'll just return to caller and leave the connect
packet queued and they are sent even though the connection is considered a failure,
which can confuse applications with unwanted false connect attempt.

The patchset enables vsock (both host and guest) to cancel queued packets when
a connect attempt is considered to fail.

v4 changelog:
 - drop two unnecessary void * cast
 - update new callback commnet
v3 changelog:
 - define cancel_pkt callback in struct vsock_transport rather than struct virtio_transport
 - rename virtio_vsock_pkt->vsk to virtio_vsock_pkt->cancel_token
v2 changelog:
 - fix queued_replies counting and resume tx/rx when necessary

Cheers,
Tao

Peng Tao (4):
 vsock: track pkt owner vsock
 vhost-vsock: add pkt cancel capability
 vsock: add pkt cancel capability
 vsock: cancel packets when failing to connect

drivers/vhost/vsock.c                   | 41 ++++++++++++++++++++++++++++++++
include/linux/virtio_vsock.h            |  2 ++
include/net/af_vsock.h                  |  3 +++
net/vmw_vsock/af_vsock.c                | 14 +++++++++++
net/vmw_vsock/virtio_transport.c        | 42 +++++++++++++++++++++++++++++++++
net/vmw_vsock/virtio_transport_common.c |  7 ++++++
6 files changed, 109 insertions(+)

--
2.7.4

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
ping~

It looks like the patchsets are reviewed but not merged. Is there any blocker?
If Jorgen is sending pull requests then it should go through him.

Otherwise David Miller could apply it.
We are usually not involved in applying changes from outside VMware; those are applied by David Miller.

Thanks,
Jørgen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help