Thread (8 messages) flat view 8 messages, 3 authors, 2017-01-16

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

From: David Miller <davem@davemloft.net>
Date: 2017-01-16 16:46:12

From: Shyam Saini <redacted>
Date: Mon, 16 Jan 2017 14:54:35 +0530
On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote:
quoted
Please do not ever submit two patches which have the same exact commit
header line, as these two patches do.

When someone looks into the shortlog of GIT history all they will see
is "qed: Replace memset with eth_zero_addr" twice.

This gives the reader no idea what might be different between those
two changes.

Therefore you must give unique a commit header text for each change,
which communicates sufficiently what is different in each change.
Thanks a lot for correcting me. I'll take care of this thing.

I'm resending these two patches as 
	1). qed: Replace memset with eth_zero_addr
	2). qed: Use eth_zero_addr
	
I hope it resolves same commit header line conflict.
You aren't understanding the point.

Those two lines still say exactly the same thing.

What is different about these two changes?  The answer to that question
must propagate into those lines of text.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help