Re: [PATCH for bnxt_re V3 03/21] bnxt_re: register with the NIC driver

On Mon, Jan 16, 2017 at 01:38:40PM +0530, Selvin Xavier wrote:

On Mon, Jan 16, 2017 at 1:11 AM, Leon Romanovsky [off-list ref] wrote:

quoted

Recently, in one of our submission to netdev and rdma, we got
a reminder that inline functions shouldn't be in *.c. Let for
the compiler to decide.

IMHO, it should be open-coded without wrappers and honestly I failed to
understand why do you need so many wrappers for one line standard kernel
functions.

Agreed. During the initial days of development, we had some debug code also
inside these wrapper functions. Since the debug code was removed before upstream
submission, this function ended up as a wrapper for standard kernel function.
It makes perfect sense to knock off these wrapper functions. I will
queue it for next
clean-up/bug fix patch series.

I'm fine with it as long as it's done.

Thanks