Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

Sun, Jan 15, 2017 at 04:18:20PM CET, jhs@mojatatu.com wrote:

On 17-01-15 10:01 AM, Jiri Pirko wrote:

quoted

Sun, Jan 15, 2017 at 03:01:19PM CET, jhs@mojatatu.com wrote:

quoted

quoted

+cls_set_class(struct tcf_proto *tp, unsigned long *clp,

??

quoted

	unsigned long cl)
{
	unsigned long old_cl;
-	
+

??

quoted

	tcf_tree_lock(tp);
	old_cl = __cls_set_class(clp, cl);
	tcf_tree_unlock(tp);
-
+

??

quoted

	return old_cl;
}

@@ -237,7 +237,7 @@ static inline int tcf_em_early_end(struct tcf_ematch *em, int result)

	return 0;
}
-	
+

??

All these things with "??" were annoying whitespace and stylistic
things my fingers couldnt resist. It is legit to include such changes
in a patch when touching the code (as long as not a bug fix).

Well, I think you should change this in a separate patch as it has 0
relation with this patch.