Thread (14 messages) 14 messages, 3 authors, 2017-01-17

Re: [net PATCH v4 0/6] virtio_net XDP fixes and adjust_header support

From: Jason Wang <jasowang@redhat.com>
Date: 2017-01-16 05:51:39


On 2017年01月16日 07:59, John Fastabend wrote:
This has a fix to handle small buffer free logic correctly and then
also adds adjust head support.

I pushed adjust head at net (even though its rc3) to avoid having
to push another exception case into virtio_net to catch if the
program uses adjust_head and then block it. If there are any strong
objections to this we can push it at net-next and use a patch from
Jakub to add the exception handling but then user space has to deal
with it either via try/fail logic or via kernel version checks. Granted
we already have some cases that need to be configured to enable XDP
but I don't see any reason to have yet another one when we can fix it
now vs delaying a kernel version.


v2: fix spelling error, convert unsigned -> unsigned int
v3: v2 git crashed during send so retrying sorry for the noise
v4: changed layout of rtnl_lock fixes (Stephen)
     moved reset logic into virtio core with new patch (MST)
     fixed up linearize and some code cleanup (Jason)

     Otherwise did some generic code cleanup so might be a bit
     cleaner this time at least that is the hope.

Thanks everyone for the v3 review.
Thanks, looks good to me overall, just few nits.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help