Thread (3 messages) 3 messages, 2 authors, 2017-01-15

Re: net: stmmac: don't use netdev_[dbg, info, ..] before net_device is registered

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2017-01-15 18:29:00

Am 15.01.2017 um 19:23 schrieb Joe Perches:
On Sun, 2017-01-15 at 19:17 +0100, Heiner Kallweit wrote:
quoted
Don't use netdev_info and friends before the net_device is registered.
This avoids ugly messages like
"meson8b-dwmac c9410000.ethernet (unnamed net_device) (uninitialized):
Enable RX Mitigation via HW Watchdog Timer"
It'd be nice to mention the new message prefix.
Sorry, I thought it's obvious because here the message trail looks
like this:

meson8b-dwmac c9410000.ethernet: DMA HW capability register supported
meson8b-dwmac c9410000.ethernet: Normal descriptors
meson8b-dwmac c9410000.ethernet: RX Checksum Offload Engine supported
meson8b-dwmac c9410000.ethernet: COE Type 2
meson8b-dwmac c9410000.ethernet: TX Checksum insertion supported
meson8b-dwmac c9410000.ethernet: Wake-Up On Lan supported
meson8b-dwmac c9410000.ethernet (unnamed net_device) (uninitialized): Enable RX Mitigation via HW Watchdog Timer

Better update the commit message and send a v2?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help