Re: [PATCH] synopsys: remove dwc_eth_qos driver
From: Niklas Cassel <hidden>
Date: 2017-01-13 09:27:03
On 01/12/2017 04:54 PM, Joao Pinto wrote:
Às 3:48 PM de 1/12/2017, David Miller escreveu:quoted
From: Joao Pinto <redacted> Date: Thu, 12 Jan 2017 15:46:31 +0000quoted
Hope we can meet in a LinuxCon soon and have a talk, for you to know me and this way you will see that I am a guy that is only focused in producing work the best way possible, and nothing else.I do not argue your intentions. I argue the side effects of your change for the ecosystem of long term maintaince and backporting, and what tangible benefit this change brings to users.The driver synopsys/dwc_eth_qos is no longer necessary since it was ported to stmmac. The merged followed all the requirements given by AXIS coleagues Niklas and Lars. The new stmmac solution was tested by them. In my opinion of course there is no reason to synopsys/dwc_eth_qos to exist anymore. I am deleting now a synopsys/ name folder :) I did this work to improve organization and centralize dwc ethernet in stmmac.
Hello Joao, David. Regardless of the outcome of the "to rename or not to rename" discussion, I think that merging this patch would be a good thing. Joao's dwc_eth_qos glue layer has been merged to stmmac, so it should now be safe to remove the dwc_eth_qos driver. It's much better if everyone is focusing on a single driver.
I know that changing what is working properly is a risk, I totally understand, and if I was a top maintainer I would have the same concern of course. But in this case I think it is good to organize the house. My intentions are to stick around and help developing Ethernet, like I am helping developing PCI host/. Thanks, Joao