Re: [PATCH] [v2] net: qcom/emac: grab a reference to the phydev on ACPI systems

From
Johan Hovold <johan@kernel.org>
Date
2017-01-12 09:07:58
Reply to
Timur Tabi, 2017-01-11
On Wed, Jan 11, 2017 at 04:45:51PM -0600, Timur Tabi wrote:
Commit 6ffe1c4cd0a7 ("net: qcom/emac: fix of_node and phydev leaks")
fixed the problem with reference leaks on phydev, but the fix is
device-tree specific.  When the driver unloads, the reference is
dropped only on DT systems.

Instead, it's cleaner if up grab an reference on ACPI systems.
When the driver unloads, we can drop the reference without having
to check whether we're on a DT system.

Signed-off-by: Timur Tabi <redacted>
Reviewed-by: Johan Hovold <johan@kernel.org>
Thread (3 messages) 3 messages, 3 authors, last reply 2017-01-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help