Re: [PATCH net-next] liquidio: store the L4 hash of rx packets in skb

From: Felix Manlunas <redacted>
Date: Mon, 9 Jan 2017 10:45:05 -0800

David Miller [off-list ref] wrote on Sun [2017-Jan-08 17:09:41 -0500]:

quoted

From: Felix Manlunas <redacted>
Date: Fri, 6 Jan 2017 16:55:42 -0800

quoted

 
+		if (rh->r_dh.has_hash) {
+			u32 hash = be32_to_cpu(*(u32 *)(skb->data + r_dh_off));

Is the checksum defined to be in the first 4-bytes of the 8-byte DHLEN unit,
or the second 4-bytes?  Is the answer to this question endian-dependent?

The hash is always in the first 4-bytes.  The location of the hash is endian
independent.  The hash itself (in its original form) is big endian.

Thanks for explaining.

Please fix the SPARSE issue Eric Dumazet mentioned.