Re: [for-next 07/10] IB/mlx5: Use blue flame register allocator in mlx5_ib

On Fri, Jan 06, 2017 at 11:11:31AM -0500, David Miller wrote:

From: Leon Romanovsky <redacted>
Date: Fri, 6 Jan 2017 08:06:09 +0200

quoted

On Thu, Jan 05, 2017 at 03:07:31PM -0500, David Miller wrote:

quoted

From: Eli Cohen <redacted>
Date: Thu, 5 Jan 2017 14:03:18 -0600

quoted

If necessary I can make sure it builds on 32 bits as well.

Please do.

Dave,

I'm failing to understand the benefits of building mlx5 on 32 bits, and
see only disadvantages:
 * It is actual dead code without test coverage.
 * It misleads reviewers/customers by seeing code for 32 bits.
 * It adds compilation time for 32 bits platforms and "punishes" them
   for not relevant for them driver.

Why do you call removing all that as a "regression"?

We have this thing called "CONFIG_COMPILE_TEST", it has tons of value,
perhaps you've seen it before?

Thanks David,
I see your point.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html