Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

On Fri, 6 Jan 2017 18:30:35 +0100, Jiri Pirko wrote:

quoted

quoted

quoted

+	skb_dst_drop(skb);
+	dst_hold(&priv->vfpr_dst->dst);
+	skb_dst_set(skb, &priv->vfpr_dst->dst);
+	skb->dev = vsi->netdev;  

This dst dance seems a bit odd to me. Why don't you just call
i40e_xmit_frame_ring with an extra arg holding the needed metadata?  

We don't have TX/RX queues associated with VFPR netdevs, so we need to set
the dev to PF netdev and requeue the skb.  

Still, you eventually call a function within same .c file. Using dst
does not look right to me.

Do you mean you don't like reusing the dst_metadata to store the
representative id?  The missing patch provided the reasoning behind
this design [1].  It's mostly about being able to comfortably use the
queuing infrastructure.  Trying to push data from multiple netdevs into
single ring at driver layer is even less pretty.

[1] http://patchwork.ozlabs.org/patch/710563/