Thread (10 messages) 10 messages, 3 authors, 2017-01-04

Re: [PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup

From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2017-01-04 21:40:17

On Wed, Jan 04, 2017 at 09:11:57PM +0100, Daniel Borkmann wrote:
On 01/04/2017 02:18 AM, Michał Mirosław wrote:
quoted
Those patches prepare BPF ant its JITs for removal of VLAN_TAG_PRESENT.
The set depends on "Preparation for VLAN_TAG_PRESENT cleanup" patchset.

The series is supposed to be bisect-friendly and that requires temporary
insertion of #define VLAN_TAG_PRESENT in BPF code to be able to split
JIT changes per architecture.

Michał Mirosław (6):
   net/skbuff: add macros for VLAN_PRESENT bit
   net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI
   net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI
   net/bpf_jit: PPC: split VLAN_PRESENT bit handling from VLAN_TCI
   net/bpf_jit: SPARC: split VLAN_PRESENT bit handling from VLAN_TCI
   net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI
Please add a proper changelog to all the individual patches, right now
they have none. Also, how was this runtime tested? Did you run BPF selftest
suite with them? Seems like they weren't even compile tested properly
given the kbuild bot barking on sparc ...
Compile bot is barking because it doesn't have patches, which this set depends on.
Sorry about that.

Best Regards,
Michał Mirosław
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help