Thread (12 messages) flat view 12 messages, 2 authors, 2017-01-04

Re: [PATCH net-next 2/2] tools: psock_tpacket: verify that packet was received on lo before counting it

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2017-01-04 16:24:54

On Wed, Jan 4, 2017 at 11:12 AM, Sowmini Varadhan
[off-list ref] wrote:
On (01/04/17 11:07), Willem de Bruijn wrote:
quoted
Please do. Then the patch is just a one-line change to
the third argument of the socket call. Thanks!
ok but it's going to be more than a one-line change. Today you
have
        sock = pfsocket(version);
        memset(&ring, 0, sizeof(ring));
        setup_ring(sock, &ring, version, type);
        mmap_ring(sock, &ring);
        bind_ring(sock, &ring);
        walk_ring(sock, &ring);

And the pair_udp_setfilter() only gets set up out of
walk_ring. I think you want to move that up to be done before
bind_ring.
Oh, good point. It may require some more refactoring. Feel free to
leave it for me if you prefer.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help