Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data
flat view
From: Pavel Machek <hidden>
Date: 2016-12-24 18:17:34
Also in:
linux-wireless, lkml
Hi!
In case there is no valid MAC address kernel generates random one. This patch propagate this generated MAC address back to NVS data which will be uploaded to wl1251 chip. So HW would have same MAC address as linux kernel uses.
quoted hunk ↗ jump to hunk
return 0; } +static int wl1251_write_nvs_mac(struct wl1251 *wl) +{
The name is quite confusing, this sounds like writing into non-volatile storage.
quoted hunk ↗ jump to hunk
+ int i; + + if (wl->nvs_len < 0x24) + return -ENODATA; + + /* length is 2 and data address is 0x546c (mask is 0xfffe) */
You don't actually check for the mask.
+ if (wl->nvs[0x19] != 2 || wl->nvs[0x1a] != 0x6d || wl->nvs[0x1b] != 0x54) + return -EINVAL;
You have two copies of these. Does it make sense to move it to helper function? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachments
- signature.asc [application/pgp-signature] 181 bytes