Thread (13 messages) 13 messages, 4 authors, 2016-12-21

Re: [PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

From: Mark Greer <mgreer@animalcreek.com>
Date: 2016-12-20 19:00:12
Also in: linux-devicetree, linux-wireless, lkml

On Tue, Dec 20, 2016 at 11:16:32AM -0500, Geoff Lansberry wrote:
From: Jaret Cantu <redacted>

Repeated polling attempts cause a NULL dereference error to occur.
This is because the state of the trf7970a is currently reading but
another request has been made to send a command before it has finished.
How is this happening?  Was trf7970a_abort_cmd() called and it didn't
work right?  Was it not called at all and there is a bug in the digital
layer?  More details please.
The solution is to properly kill the waiting reading (workqueue)
before failing on the send.
If the bug is in the calling code, then that is what should get fixed.
This seems to be a hack to work-around a digital layer bug.

Mark
--
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help