Thread (6 messages) flat view 6 messages, 2 authors, 2016-12-08

Re: [RESEND PATCH 2/3] net: stmmac: dwmac-generic: add missing compatible strings

From: David Miller <davem@davemloft.net>
Date: 2016-12-08 16:36:28
Also in: lkml

From: Niklas Cassel <redacted>
Date: Wed, 7 Dec 2016 13:41:07 +0100
From: Niklas Cassel <redacted>

devicetree binding for stmmac states:
- compatible: Should be "snps,dwmac-<ip_version>", "snps,dwmac"
	For backwards compatibility: "st,spear600-gmac" is also supported.

Since dwmac-generic.c calls stmmac_probe_config_dt explicitly,
another alternative would have been to remove all compatible strings
other than "snps,dwmac" and "st,spear600-gmac" from dwmac-generic.c.

However, that would probably do more good than harm, since when trying
to figure out what hardware a certain driver supports, you usually look
at the compatible strings in the struct of_device_id, and not in some
function defined in a completely different file.

No functional change intended.

Signed-off-by: Niklas Cassel <redacted>
Acked-by: Giuseppe Cavallaro <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help