Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

From
Michael S. Tsirkin <mst@redhat.com>
Date
2016-12-08 05:54:11
Also in
dri-devel, kvm, linux-crypto, linux-kbuild, linux-s390, linux-scsi, lkml, virtualization
Reply to
Bart Van Assche, 2016-12-08
On Thu, Dec 08, 2016 at 05:21:47AM +0000, Bart Van Assche wrote:
On 12/07/16 18:29, Michael S. Tsirkin wrote:
quoted
By now, linux is mostly endian-clean. Enabling endian-ness
checks for everyone produces about 200 new sparse warnings for me -
less than 10% over the 2000 sparse warnings already there.

Not a big deal, OTOH enabling this helps people notice
they are introducing new bugs.

So let's just drop __CHECK_ENDIAN__. Follow-up patches
can drop distinction between __bitwise and __bitwise__.
Hello Michael,

This patch makes a whole bunch of ccflags-y += -D__CHECK_ENDIAN__ 
statements obsolete. Have you considered to remove these statements?
Absolutely. Just waiting for feedback on the idea.
Additionally, there are notable exceptions to the rule that most drivers 
are endian-clean, e.g. drivers/scsi/qla2xxx. I would appreciate it if it 
would remain possible to check such drivers with sparse without enabling 
endianness checks. Have you considered to change #ifdef __CHECK_ENDIAN__ 
into e.g. #ifndef __DONT_CHECK_ENDIAN__?

Thanks,

Bart.
The right thing is probably just to fix these, isn't it?
Until then, why not just ignore the warnings?

-- 
MST
Thread (10 messages) 10 messages, 5 authors, last reply 2016-12-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help