Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()
From: Iyappan Subramanian <hidden>
Date: 2016-12-07 20:46:54
Also in:
kernel-janitors, lkml
From: Iyappan Subramanian <hidden>
Date: 2016-12-07 20:46:54
Also in:
kernel-janitors, lkml
On Wed, Dec 7, 2016 at 3:14 AM, Dan Carpenter [off-list ref] wrote:
We never set "slots" in this function. Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame") Signed-off-by: Dan Carpenter <redacted> --- I copied how slots gets set in xgene_enet_rx_frame(). Static analysis. Not tested.diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 6c7eea8b36af..884a334e82d0 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c@@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool, return; dev = ndev_to_dev(buf_pool->ndev); + slots = buf_pool->slots - 1; head = buf_pool->head; for (i = 0; i < 4; i++) {
Thanks. Acked-by: Iyappan Subramanian <redacted>