Thread (1 message) 1 message, 1 author, 2016-12-06

Re: [PATCH] net:switchdev: fix to release the lock before function return to avoid deadlock

From: Jiri Pirko <jiri@resnulli.us>
Date: 2016-12-06 12:29:37
Also in: lkml

Tue, Dec 06, 2016 at 11:09:24AM CET, feng.deng@cortina-access.com wrote:
quoted hunk
before switchdev_deferred_dequeue() normal return,show release the lock,
if not,maybe there will be deadlock sometimes

Signed-off-by: Feng Deng <redacted>
---
net/switchdev/switchdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index 3b95fe9..c0a1ad4 100644
--- a/net/switchdev/switchdev.c
+++ b/net/switchdev/switchdev.c
@@ -120,6 +120,7 @@ static struct switchdev_deferred_item *switchdev_deferred_dequeue(void)
	dfitem = list_first_entry(&deferred,
				  struct switchdev_deferred_item, list);
	list_del(&dfitem->list);
+	spin_unlock_bh(&deferred_lock);
unlock:
	spin_unlock_bh(&deferred_lock);
You are joking right?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help