Thread (5 messages) flat view 5 messages, 3 authors, 2016-12-22

Re: [PATCH v2 net] ipvlan: fix various issues in ipvlan_process_multicast()

From: David Miller <davem@davemloft.net>
Date: 2016-12-22 16:20:30

From: Eric Dumazet <redacted>
Date: Wed, 21 Dec 2016 18:00:24 -0800
From: Eric Dumazet <edumazet@google.com>

1) netif_rx() / dev_forward_skb() should not be called from process
context.

2) ipvlan_count_rx() should be called with preemption disabled.

3) We should check if ipvlan->dev is up before feeding packets
to netif_rx()

4) We need to prevent device from disappearing if some packets
are in the multicast backlog.

5) One kfree_skb() should be a consume_skb() eventually

Fixes: ba35f8588f47 ("ipvlan: Defer multicast / broadcast processing to
a work-queue")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Mahesh Bandewar <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help