Re: [PATCH net] openvswitch: Add a missing break statement.

On Dec 19, 2016, at 5:06 PM, Jarno Rajahalme [off-list ref] wrote:

Add a break statement to prevent fall-through from
OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL.  Without the break
actions setting ethernet addresses fail to validate with log messages
complaining about invalid tunnel attributes.

Fixes: 0a6410fbde ("openvswitch: netlink: support L3 packets")
Signed-off-by: Jarno Rajahalme <redacted>
Acked-by: Pravin B Shelar <redacted>
Acked-by: Jiri Benc <redacted>
---
net/openvswitch/flow_netlink.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
index d19044f..c87d359 100644
--- a/net/openvswitch/flow_netlink.c
+++ b/net/openvswitch/flow_netlink.c

@@ -2195,6 +2195,7 @@ static int validate_set(const struct nlattr *a,

	case OVS_KEY_ATTR_ETHERNET:
		if (mac_proto != MAC_PROTO_ETHERNET)
			return -EINVAL;
+		break;

	case OVS_KEY_ATTR_TUNNEL:
		if (masked)
-- 
2.1.4