Thread (8 messages) 8 messages, 4 authors, 2016-12-09

Re: [PATCH net-next v6 0/2] net/sched: cls_flower: Support matching on ICMP

From: Simon Horman <hidden>
Date: 2016-12-09 06:44:06

Hi Dave, Hi Or,

On Thu, Dec 08, 2016 at 11:58:10AM -0500, David Miller wrote:
From: Simon Horman <redacted>
Date: Wed,  7 Dec 2016 13:48:26 +0100
quoted
this series adds support for matching on ICMP type and code to
cls_flower.
Series applied, thanks Simon.  I guess we'll see some netronome
offloading of this stuff coming soon? :-)
That is the direction I would like to see this go in.
Simon and Or, you both added extensions to cls_flower at the same
time.  Or's changes went in first, so his UAPI numbers did not change.
Simons, your changes went in next so your numbers did change and
therefore you will have to recompile any userland components you were
using for testing.

Just FYI...
On Thu, Dec 08, 2016 at 10:43:05PM +0200, Or Gerlitz wrote:
On Thu, Dec 8, 2016 at 6:58 PM, David Miller [off-list ref] wrote:
quoted
Simon and Or, you both added extensions to cls_flower at the same
time.  Or's changes went in first, so his UAPI numbers did not change.
Simons, your changes went in next so your numbers did change and
therefore you will have to recompile any userland components you were
using for testing.
Yeah, I guess you had to do some rebasing there for Simon's series...
thanks for taking care
Likewise, thanks a lot for handling the conflict.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help