Re: [net-next PATCH v5 0/6] XDP for virtio_net
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2016-12-09 03:01:40
On Thu, Dec 08, 2016 at 05:16:02PM -0500, David Miller wrote:
From: John Fastabend <john.fastabend@gmail.com> Date: Thu, 8 Dec 2016 12:46:07 -0800quoted
On 16-12-08 11:38 AM, Alexei Starovoitov wrote:quoted
On Thu, Dec 08, 2016 at 02:17:02PM -0500, David Miller wrote:quoted
From: John Fastabend <john.fastabend@gmail.com> Date: Wed, 07 Dec 2016 12:10:47 -0800quoted
This implements virtio_net for the mergeable buffers and big_packet modes. I tested this with vhost_net running on qemu and did not see any issues. For testing num_buf > 1 I added a hack to vhost driver to only but 100 bytes per buffer.... So where are we with this?There is one possible issue with a hang that Michael pointed out. I can either spin a v6 or if you pull this v5 series in I can post a bugfix for it. I am not seeing the issue in practice XDP virtio has been up and running on my box here for days without issue.If that's the case then please spin a v6 and I'll apply it.
I think 1/6 should be reworked, disabling/enabling GUEST_TSO transparently without touching the LRO flag, and without adding NDO callback. -- MST