Re: [PATCH v2 1/4] vsock: track pkt owner vsock

From
Stefan Hajnoczi <hidden>
Date
2016-12-08 09:30:10
Also in
kvm, virtualization
Reply to
Peng Tao, 2016-12-07
On Wed, Dec 07, 2016 at 11:14:09PM +0800, Peng Tao wrote:
quoted hunk ↗ jump to hunk
So that we can cancel a queued pkt later if necessary.

Signed-off-by: Peng Tao <redacted>
---
 include/linux/virtio_vsock.h            | 2 ++
 net/vmw_vsock/virtio_transport_common.c | 7 +++++++
 2 files changed, 9 insertions(+)
diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h
index 9638bfe..6dd3242 100644
--- a/include/linux/virtio_vsock.h
+++ b/include/linux/virtio_vsock.h
@@ -48,6 +48,7 @@ struct virtio_vsock_pkt {
 	struct virtio_vsock_hdr	hdr;
 	struct work_struct work;
 	struct list_head list;
+	struct vsock_sock *vsk;
To prevent future bugs, please add a comment here:
/* socket refcnt not held, only use for cancellation */

This field is just an opaque token used for cancellation rather than a
struct vsock_sock pointer that we are allowed to dereference.  You could
change this field to void *cancel_token to make the code harder to
misuse.
Thread (11 messages) 11 messages, 2 authors, last reply 2016-12-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help