Re: [PATCH net-next v5 1/2] flow dissector: ICMP support

Wed, Dec 07, 2016 at 01:14:39PM CET, simon.horman@netronome.com wrote:

Allow dissection of ICMP(V6) type and code. This should only occur
if a packet is ICMP(V6) and the dissector has FLOW_DISSECTOR_KEY_ICMP set.

There are currently no users of FLOW_DISSECTOR_KEY_ICMP.
A follow-up patch will allow FLOW_DISSECTOR_KEY_ICMP to be used by
the flower classifier.

You are missing signedoff line.