Re: [PATCH net-next V2 6/7] liquidio CN23XX: VF TX buffers
From: David Miller <davem@davemloft.net>
Date: 2016-12-07 02:59:39
From: Raghu Vatsavayi <redacted> Date: Tue, 6 Dec 2016 13:06:06 -0800
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c index cf80722..ce5cdcd 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c@@ -270,6 +270,19 @@ static void start_txq(struct net_device *netdev) } /** + * \brief Wake a queue + * @param netdev network device + * @param q which queue to wake + */ +static inline void wake_q(struct net_device *netdev, int q)
...
+static inline int skb_iq(struct lio *lio, struct sk_buff *skb)
...
+static inline int check_txq_state(struct lio *lio, struct sk_buff *skb)
Please do not mark functions inline in foo.c files, let the compiler decide.