Thread (19 messages) 19 messages, 4 authors, 2016-12-20

Re: [PATCH v3 net-next 2/3] openvswitch: Use is_skb_forwardable() for length check.

From: Pravin Shelar <hidden>
Date: 2016-12-01 19:50:06

On Wed, Nov 30, 2016 at 5:51 AM, Jiri Benc [off-list ref] wrote:
On Tue, 29 Nov 2016 15:30:52 -0800, Jarno Rajahalme wrote:
quoted
@@ -504,11 +485,20 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto)
              goto drop;
      }

-     if (unlikely(packet_length(skb, vport->dev) > mtu &&
-                  !skb_is_gso(skb))) {
-             net_warn_ratelimited("%s: dropped over-mtu packet: %d > %d\n",
-                                  vport->dev->name,
-                                  packet_length(skb, vport->dev), mtu);
+     if (unlikely(!is_skb_forwardable(vport->dev, skb))) {
How does this work when the vlan tag is accelerated? Then we can be
over MTU, yet the check will pass.
This is not changing any behavior compared to current OVS vlan checks.
Single vlan header is not considered for MTU check.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help