Thread (2 messages) flat view 2 messages, 2 authors, 2016-11-28

Re: [PATCH] vxlan: fix a potential issue when create a new vxlan fdb entry.

From: Jiri Benc <hidden>
Date: 2016-11-28 11:37:52
Also in: lkml

On Mon, 28 Nov 2016 15:02:23 +0800, Haishuang Yan wrote:
quoted hunk ↗ jump to hunk
vxlan_fdb_append may return error, so add the proper check,
otherwise it will cause memory leak.

Signed-off-by: Haishuang Yan <redacted>
---
 drivers/net/vxlan.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 21e92be..3b7b237 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -611,6 +611,7 @@ static int vxlan_fdb_create(struct vxlan_dev *vxlan,
 	struct vxlan_rdst *rd = NULL;
 	struct vxlan_fdb *f;
 	int notify = 0;
+	int rc = 0;
The initialization to 0 should not be needed. Looks good otherwise.

Thanks,

 Jiri
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help