Thread (63 messages) 63 messages, 9 authors, 2019-01-07

RE: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

From: Hayes Wang <hidden>
Date: 2016-11-24 12:37:40
Also in: lkml

Possibly related (same subject, not in this thread)

Mark Lord [mailto:mlord@pobox.com]
Sent: Wednesday, November 23, 2016 9:41 PM
[...] 
quoted
static void r8153_set_rx_early_size(struct r8152 *tp)
{
       u32 mtu = tp->netdev->mtu;
       u32 ocp_data = (agg_buf_sz - mtu - VLAN_ETH_HLEN - VLAN_HLEN) / 4;

       ocp_write_word(tp, MCU_TYPE_USB, USB_RX_EARLY_SIZE, ocp_data);
}
How is ocp_data used by the hardware?
Shouldn't the calculation also include sizeof(rx_desc) in there somewhere?
I check your question with our hw engineers, and you are right.
The size of rx descriptor should be calculated, too.

Best Regards,
Hayes

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help