Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

On Wed, Nov 16, 2016 at 03:51:30PM +0100, Jerome Brunet wrote:

On Wed, 2016-11-16 at 14:23 +0100, Andrew Lunn wrote:

quoted

quoted

There two kind of PHYs supporting eee, the one advertising eee by
default (like realtek) and the one not advertising it (like
micrel).

This is just the default register value.

quoted

I don't know too much about EEE. So maybe a dumb question. Does the
MAC need to be involved? Or is it just the PHY?

If the MAC needs to be involved, the PHY should not be advertising
EEE
unless the MAC asks for it by calling phy_init_eee(). If this is
true,
maybe we need to change the realtek driver, and others in that class.

As far I understand, the advertised capabilities are exchanged during
the auto-negotiation.

At this stage, if the advertisement is disabled (regarless of the
actual support) on either side of the link, there will be no low power
idle state on the Tx nor the Rx path.

If the advertisement is enabled on both side but we don't call
phy_init_eee, I suppose Tx won't enter LPI, but Rx could.

What i was trying to find out is, if the MAC needs to support EEE as
well as the PHY, what happens when the MAC does not support EEE, but
the PHYs do negotiate EEE? Does it break?

    Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html