On Wed, Nov 9 2016, 06:02 PM, Greg KH wrote:

On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote:

quoted

This driver enables Thunderbolt Networking on non-Apple platforms
running Linux.

Thunderbolt Networking provides peer-to-peer connections to transfer
files between computers, perform PC migrations, and/or set up small
workgroups with shared storage.

This is a virtual connection that emulates an Ethernet adapter that
enables Ethernet networking with the benefit of Thunderbolt superfast
medium capability.

Thunderbolt Networking enables two hosts and several devices that have
a Thunderbolt controller to be connected together in a linear (Daisy
chain) series from a single port.

Thunderbolt Networking for Linux is compatible with Thunderbolt
Networking on systems running macOS or Windows and also supports
Thunderbolt generation 2 and 3 controllers.

Note that all pre-existing Thunderbolt generation 3 features, such as
USB, Display and other Thunderbolt device connectivity will continue
to function exactly as they did prior to enabling Thunderbolt Networking.

Code and Software Specifications:
This kernel code creates a virtual ethernet device for computer to
computer communication over a Thunderbolt cable.
The new driver is a separate driver to the existing Thunderbolt driver.
It is designed to work on systems running Linux that interface with
Intel Connection Manager (ICM) firmware based Thunderbolt controllers
that support Thunderbolt Networking.
The kernel code operates in coordination with the Thunderbolt user-
space daemon to implement full Thunderbolt networking functionality.

Hardware Specifications:
Thunderbolt Hardware specs have not yet been published but are used
where necessary for register definitions.

Acked-by: Andreas Noever <andreas.noever@gmail.com>
Tested-by: Mario Limonciello <redacted>

This whole series is acked and tested by these people?  If so, why did you not
include that in each patch?

Will add in next patch set.

And how about getting some internal-Intel kernel developers to review and
sign-off on this code?  Don't make the community do the review when you
have access to resources like this.  You have an internal mailing list for this
very purpose, use it!

The review with the internal-Intel kernel developers was done before submitting
the first patch set.
Version 9 that we have here isn't so different from Version 0.

thanks,

greg k-h