[PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4
From: Zhiyi Sun <hidden>
Date: 2016-11-09 07:35:53
Also in:
linux-rdma, lkml
Subsystem:
mellanox ethernet driver (mlx4_en), mellanox mlx4 core vpi driver, networking drivers, the rest · Maintainers:
Tariq Toukan, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
There are rx_ring_num queues. Each queue will load xdp prog. So bpf_prog_add() should add rx_ring_num to ref_cnt. Signed-off-by: Zhiyi Sun <redacted> --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 12c99a2..d25e150 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c@@ -2650,7 +2650,7 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog) */ if (priv->xdp_ring_num == xdp_ring_num) { if (prog) { - prog = bpf_prog_add(prog, priv->rx_ring_num - 1); + prog = bpf_prog_add(prog, priv->rx_ring_num); if (IS_ERR(prog)) return PTR_ERR(prog); }
@@ -2680,7 +2680,7 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog) } if (prog) { - prog = bpf_prog_add(prog, priv->rx_ring_num - 1); + prog = bpf_prog_add(prog, priv->rx_ring_num); if (IS_ERR(prog)) return PTR_ERR(prog); }
--
2.9.3